Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): allow overriding client hmr options #6082

Merged
merged 4 commits into from
Jul 25, 2022
Merged

fix(vite): allow overriding client hmr options #6082

merged 4 commits into from
Jul 25, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#14371

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This fixes a regression in upgrade to Vite 3. Our client config should only contain what we want to override the basic user config, and HMR is probably in the list of things that should be configurable.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working vite πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Jul 23, 2022
@danielroe danielroe requested a review from pi0 July 23, 2022 10:06
@danielroe danielroe self-assigned this Jul 23, 2022
@netlify
Copy link

netlify bot commented Jul 23, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit b64868e
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62de8a8b4c648900091a3e5f

packages/vite/src/server.ts Outdated Show resolved Hide resolved
packages/vite/src/client.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title fix(vite): move hmr settings to defaults, not overrides fix(vite): allow overriding client hmr options Jul 25, 2022
@pi0 pi0 merged commit 8298cf2 into main Jul 25, 2022
@pi0 pi0 deleted the fix/vite-user-hmr branch July 25, 2022 12:29
@pi0 pi0 mentioned this pull request Aug 5, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage vite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite HMR user settings not being respected
2 participants